From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6764 invoked by alias); 13 Aug 2014 04:11:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6727 invoked by uid 89); 13 Aug 2014 04:11:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Aug 2014 04:11:14 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1XHPu2-0001bj-VV from Yao_Qi@mentor.com ; Tue, 12 Aug 2014 21:11:10 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 12 Aug 2014 21:11:10 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Tue, 12 Aug 2014 21:11:10 -0700 Message-ID: <53EAE47A.6030700@codesourcery.com> Date: Wed, 13 Aug 2014 04:11:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Eli Zaretskii , Subject: Re: Warnings in native MinGW32 build of GDB 7.8 References: <83r40plpp3.fsf@gnu.org> In-Reply-To: <83r40plpp3.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00210.txt.bz2 On 08/09/2014 10:09 PM, Eli Zaretskii wrote: > I fixed that as below, but I wonder why no one else saw this. is this > because I use an ancient version of GCC? I don't see any warning in my mingw32 build. I am using i686-w64-mingw32-gcc 4.8.2. > > OK to commit the below (master and 7.8 branch), with suitable > ChangeLog entries? > > --- gdb/dcache.c~0 2014-07-29 15:37:42.000000000 +0300 > +++ gdb/dcache.c 2014-08-09 16:17:31.823000000 +0300 > @@ -18,6 +18,7 @@ > along with this program. If not, see . */ > > #include "defs.h" > +#include "target.h" /* for 'enum target_xfer_status' */ I can see enum target_xfer_status is used in this c file. This is good to me. > #include "dcache.h" > #include "gdbcmd.h" > #include > > --- gdb/defs.h~0 2014-07-29 15:37:42.000000000 +0300 > +++ gdb/defs.h 2014-08-09 15:33:59.666750000 +0300 > @@ -628,6 +628,7 @@ > #endif /* alloca not defined */ > > /* Dynamic target-system-dependent parameters for GDB. */ > +#include "frame.h" /* for 'struct frame_id' */ It is unclear to me why do we need this include? > #include "gdbarch.h" > > /* * Maximum size of a register. Something small, but large enough for > > --- gdb/target-dcache.c~0 2014-06-11 19:34:41.000000000 +0300 > +++ gdb/target-dcache.c 2014-08-09 16:17:42.244875000 +0300 > @@ -16,6 +16,7 @@ > along with this program. If not, see . */ > > #include "defs.h" > +#include "target.h" /* for 'enum target_xfer_status' */ enum target_xfer_status isn't used in target-dcache.c. Do we really need this? -- Yao (齐尧)