From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17553 invoked by alias); 13 Aug 2014 00:56:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17540 invoked by uid 89); 13 Aug 2014 00:56:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Aug 2014 00:56:14 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1XHMrK-0005If-DK from Yao_Qi@mentor.com ; Tue, 12 Aug 2014 17:56:10 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 12 Aug 2014 17:56:10 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Tue, 12 Aug 2014 17:56:09 -0700 Message-ID: <53EAB6C4.40406@codesourcery.com> Date: Wed, 13 Aug 2014 00:56:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Doug Evans CC: Subject: Re: [PATCH] Copy .py files to remote host References: <1407849103-16521-1-git-send-email-yao@codesourcery.com> <21482.19388.251662.22760@ruffy.mtv.corp.google.com> In-Reply-To: <21482.19388.251662.22760@ruffy.mtv.corp.google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00206.txt.bz2 On 08/13/2014 01:15 AM, Doug Evans wrote: > I still have an outstanding question on this topic, > and before this gets checked in I'd like to get it resolved. > Do we delete other files downloaded to the remote target? Yes, at least shared libs downloaded to target are cleaned up. In lib/gdb.exp, there is a list cleanfiles, to record the files downloaded to target, and in gdb_finish, remove files in this list. > > At one point I tried to find a place there the testsuite code was > taking care to delete other downloaded files, but couldn't. > Since we've gotten by this long without doing so > [and this is *still* just a hypothesis - I haven't worked with > remote hosts in awhile ...] > I would rather just punt on deleting python files as well, > and document that that is the convention (since for every other > file it already is :-)). > [Why treat python files differently?] Where can we document this convention? gdb/testsuite/README? I can't find a proper one. Existing test cases are good documentation to me, and people usually follow the existing tests when they create new ones. > > If we really did want to fully clean up after each test, > and we should first establish that that is indeed what we want to do, > instead of filling every test exit point with explicit code to delete > only one kind of downloaded file, how about instead keep a list of all > downloaded files and call a routine to delete the files in that list > from some central cleanup point? Yeah, I also dislike writing "remote_file host delete $FOO" at the each test exit point explicitly. Not sure what do you want in "fully clean up", but at least, we can clean up python files as you said. -- Yao (齐尧)