From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17958 invoked by alias); 7 Aug 2014 04:56:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17927 invoked by uid 89); 7 Aug 2014 04:56:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-pd0-f176.google.com Received: from mail-pd0-f176.google.com (HELO mail-pd0-f176.google.com) (209.85.192.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 Aug 2014 04:56:43 +0000 Received: by mail-pd0-f176.google.com with SMTP id y10so4518077pdj.21 for ; Wed, 06 Aug 2014 21:56:41 -0700 (PDT) X-Received: by 10.66.139.6 with SMTP id qu6mr209189pab.134.1407387401629; Wed, 06 Aug 2014 21:56:41 -0700 (PDT) Received: from [192.168.1.23] ([124.127.118.42]) by mx.google.com with ESMTPSA id oz7sm4435278pdb.77.2014.08.06.21.56.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Aug 2014 21:56:41 -0700 (PDT) Message-ID: <53E30702.1040709@gmail.com> Date: Thu, 07 Aug 2014 04:56:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: hjl.tools@gmail.com, nickc@redhat.com, binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] bfd/coff-ppc.c: Be sure of zero terminated string after copy from '_n_name' References: <53E24F3F.2050701@gmail.com> <20140807015153.GV8921@bubble.grove.modra.org> In-Reply-To: <20140807015153.GV8921@bubble.grove.modra.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-08/txt/msg00127.txt.bz2 On 08/07/2014 09:51 AM, Alan Modra wrote: > On Wed, Aug 06, 2014 at 11:52:31PM +0800, Chen Gang wrote: >> '_n_name' may not be zero terminated string, and it may copy to 'name' >> or 'my_name' which are assumed that must be zero terminated string. So >> during copy operation, need be sure of them zero terminated. >> >> Also remove the usless asignment to 'name'. >> >> 2014-08-06 Chen Gang >> >> * coff-ppc.c (coff_ppc_relocate_section): Be sure of zero >> terminatedstring after copy from '_n_name'. > > This is OK. > Excuse me, my English is not quite well, I don't quite understand your meaning, I guess your meaning is: "This patch is OK to you, if no any objections next, it can be applied by the related maintainers". If what I guess is incorrect, please let me know. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed