Re: [PATCH 2/2] mi-out: Implement mi redirection using a stack.

Tom Tromey
2014-07-24T18:19:19Z

>>>>> "Adrian" == Adrian Sendroiu <adrian.sendroiu@freescale.com> writes:

Adrian> gdb/
Adrian> 2014-07-23 Adrian Sendroiu <adrian.sendroiu@freescale.com>

Adrian> * mi/mi-out.c (ui_filep): New typedef.
[...]

I think it would be good to have some text in the message describing the
rationale for this patch.

One nit below.

Adrian> /* FIXME: This code should be using a ``string_file'' and not the
Adrian> TUI buffer hack. */

Not your problem but I wonder what this FIXME comment means.
I suspect it's obsolete since as far as I know mem_fileopen does return
a "string_file".

Adrian> + new_stream = mem_fileopen();

Space before the open paren.

The patch is ok with this fixed and with some rationale text.

thanks,
Tom