Re: [PATCH 13/13] Include string.h in common-defs.h

Gary Benson
2014-08-07T08:13:14Z

Doug Evans wrote:
> Gary Benson writes:
> > This commit includes string.h in common-defs.h and removes all
> > other inclusions.
> >
> > gdb/
> > 2014-07-29 Gary Benson <gbenson@redhat.com>
> >
> > * common/common-defs.h: Include string.h.
> > * aarch64-tdep.c: Do not include string.h.
> > * ada-exp.y: Likewise.
[snip]
> > * xtensa-linux-nat.c: Likewise.
> > [... zoinks! :-) ...]
>
> Fwiw, I'd be happy with replacing all of this with:
>
> * common/common-defs.h: Include string.h.
> All other uses deleted.
>
> [and similarly elsewhere]
>
> No need to go back and change anything though.
> Just my $0.02.
> Some may have a rule to write this as you've done,
> but I think this is another case where we're bogging
> ourselves down in pedantic administrivia.

Ok, I'll do that next time.

Cheers,
Gary

--