From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21047 invoked by alias); 29 Jul 2014 10:27:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21026 invoked by uid 89); 29 Jul 2014 10:27:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Jul 2014 10:27:53 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6TARpTo002939 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 29 Jul 2014 06:27:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6TARoqT031945; Tue, 29 Jul 2014 06:27:51 -0400 Message-ID: <53D77726.6060106@redhat.com> Date: Tue, 29 Jul 2014 11:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] make "set debug target" take effect immediately References: <1406574267-5212-1-git-send-email-tromey@redhat.com> In-Reply-To: <1406574267-5212-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00715.txt.bz2 On 07/28/2014 08:04 PM, Tom Tromey wrote: > Right now, "set debug target" acts a bit strangely. > > Most target APIs only notice that it has changed when the target stack > is changed in some way. This is because many methods implement the > setting using the special debug target. However, a few spots do > change their behavior immediately -- any place explicitly checking > "targetdebug". > > Some of this peculiar behavior is documented. However, I think that > it just isn't very useful for it to work this way. So, This patch > changes "set debug target" to take effect immediately in all cases. Definitely. Thanks! > This is done by simply calling update_current_target when the setting > is changed. Pedro Alves