From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21176 invoked by alias); 29 Jul 2014 07:22:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21141 invoked by uid 89); 29 Jul 2014 07:22:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Jul 2014 07:22:34 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1XC1jy-0001FD-E3 from Yao_Qi@mentor.com ; Tue, 29 Jul 2014 00:22:30 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 29 Jul 2014 00:22:30 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Tue, 29 Jul 2014 00:22:33 -0700 Message-ID: <53D74AE0.3050404@codesourcery.com> Date: Tue, 29 Jul 2014 10:07:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Tom Tromey , Subject: Re: [PATCH] make "set debug target" take effect immediately References: <1406574267-5212-1-git-send-email-tromey@redhat.com> In-Reply-To: <1406574267-5212-1-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00713.txt.bz2 On 07/29/2014 03:04 AM, Tom Tromey wrote: > diff --git a/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp b/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp > index a196f68..dd793bd 100644 > --- a/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp > +++ b/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp > @@ -76,7 +76,7 @@ if { $hardware_step } { > return > } > > -gdb_test_no_output "set debug target 0" > +gdb_test "set debug target 0" "->to_log_command.*\\)" > > set line_re "\[^\r\n\]*" Tom, Beside this change, we still need to update the pattern to match the output of "set debug target 1". We match "target_resume " nowadays, but it doesn't exist in the output at all, because of the recent target delegation changes. In sss-bp-on-user-bp-2.exp, we have gdb_test_no_output "set debug target 1" set hardware_step 0 set test "probe target hardware step" gdb_test_multiple "si" $test { -re "target_resume \\(\[^\r\n\]+, step, .*$gdb_prompt $" { ^^^^^^^^^^^^^ set hardware_step 1 pass $test } -re "$gdb_prompt $" { pass $test } } We need to replace "target_resume" with "to_resume" in the pattern, otherwise, hardware_step is always zero, which is wrong. Even hardware_step is zero on x86, the test only fails once in about 10 runs. That may be the reason we didn't find the mistake before. -- Yao (齐尧)