From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3730 invoked by alias); 25 Jul 2014 11:46:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3721 invoked by uid 89); 25 Jul 2014 11:46:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 25 Jul 2014 11:46:25 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6PBkN9L022578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Jul 2014 07:46:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6PBkK9k025682; Fri, 25 Jul 2014 07:46:21 -0400 Message-ID: <53D2438C.8040009@redhat.com> Date: Fri, 25 Jul 2014 12:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson CC: Doug Evans , gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h References: <1406206287-6817-1-git-send-email-gbenson@redhat.com> <1406206287-6817-2-git-send-email-gbenson@redhat.com> <53D1053E.6030902@redhat.com> <21457.18385.59886.323894@ruffy.mtv.corp.google.com> <20140725083642.GA4812@blade.nx> <53D22F22.4030101@redhat.com> <20140725111653.GA6301@blade.nx> In-Reply-To: <20140725111653.GA6301@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00668.txt.bz2 On 07/25/2014 12:16 PM, Gary Benson wrote: > Pedro Alves wrote: >> On 07/25/2014 09:36 AM, Gary Benson wrote: >>> I'm working on this now. My plan is to have gdb/common/common-defs.h >>> (which includes config.h and the correct gnulib config.h) and have >>> defs.h and server.h include common-defs.h as the first line. By the >>> end of that series most every file will include defs.h or server.h >>> and no file will include config.h. >> >> I think you meant, that files in gdb will include defs.h, files in >> gdbserver will include server.h, and files in the shared directories >> will include common-defs.h as the first line. > > Yes, eventually. I plan to submit an initial series, in which > common-defs.h only includes the two config.h files, and any files > not including either defs.h or server.h as their first line will > be fixed up. If that proves acceptable, I'll submit one or more > further series to move the various includes currently common to > defs.h and server.h into common-defs.h, and finally something to > switch common/target/nat files over to common-defs.h. Sounds good to me. I've distilled this into the wiki: https://sourceware.org/gdb/wiki/Common#Header_files_in_common_code_.28defs.h_vs_server.h.2C_etc..29 Please do feel free to edit it / improve it. (obviously that can evolve if the plan is objected to and changes.) -- Thanks, Pedro Alves