From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32443 invoked by alias); 25 Jul 2014 10:19:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32429 invoked by uid 89); 25 Jul 2014 10:19:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 25 Jul 2014 10:19:20 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6PAJHY0008724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Jul 2014 06:19:17 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6PAJEQ6014335; Fri, 25 Jul 2014 06:19:15 -0400 Message-ID: <53D22F22.4030101@redhat.com> Date: Fri, 25 Jul 2014 10:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson , Doug Evans CC: Pedro Alves , gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h References: <1406206287-6817-1-git-send-email-gbenson@redhat.com> <1406206287-6817-2-git-send-email-gbenson@redhat.com> <53D1053E.6030902@redhat.com> <21457.18385.59886.323894@ruffy.mtv.corp.google.com> <20140725083642.GA4812@blade.nx> In-Reply-To: <20140725083642.GA4812@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00663.txt.bz2 On 07/25/2014 09:36 AM, Gary Benson wrote: > I'm working on this now. My plan is to have gdb/common/common-defs.h > (which includes config.h and the correct gnulib config.h) and have > defs.h and server.h include common-defs.h as the first line. By the > end of that series most every file will include defs.h or server.h > and no file will include config.h. I think you meant, that files in gdb will include defs.h, files in gdbserver will include server.h, and files in the shared directories will include common-defs.h as the first line. > At the first instance common-defs.h will include most files included > by both defs.h and server.h. There are various workarounds for > various things in both, and it would be good to have these workarounds > the same for all of GDB/gdbserver/etc. I plan to omit alloca.h and > errno.h initially, as these have pretty heavy hacking around them and > they're not needed yet. I'll probably do both at some point, but as > individual patches/serieses. > > I'm also going to do some #include cleanups as part of the same > series. For example lots of things include common-utils.h, but > that's currently included by defs.h and server.h (so I'll move it > to common-defs.h) and if every file includes common-defs.h somehow > then nothing needs common-utils.h. > > Once the common-defs.h series is finished and pushed I'll rebase > this common-cleanups series on top of it. It'll be much cleaner > and by then the number of "#ifdef GDBSERVER"s in the codebase > will be precisely one (to select the appropriate gnulib config.h > in common-defs.h). > > Does all this sound ok? It does to me. -- Thanks, Pedro Alves