From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6554 invoked by alias); 25 Jul 2014 01:41:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6525 invoked by uid 89); 25 Jul 2014 01:41:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Jul 2014 01:41:03 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1XAUVI-0001iK-ER from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 24 Jul 2014 18:41:00 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 24 Jul 2014 18:41:00 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Thu, 24 Jul 2014 18:40:57 -0700 Message-ID: <53D1B4CC.4010004@codesourcery.com> Date: Fri, 25 Jul 2014 08:36:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "Maciej W. Rozycki" , Subject: Re: [PATCH 1/2] GDB/testsuite: Avoid timeout lowering References: In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00656.txt.bz2 On 07/25/2014 06:38 AM, Maciej W. Rozycki wrote: > With the timeout selection code from gdb_test_multiple gone, gone is also > the most prominent use of this timeout argument, it's now used in a couple > of places only, mostly within this test framework library code itself for > preparatory commands or suchlike. With this being the case this timeout > selection code can be simplified as follows: > > 1. Among the three timeout variables, the highest is always chosen. This > is so that a test case doesn't inadvertently lower a high value timeout > needed by slow target boards. This is what all test cases use. > > 2. Any timeout argument takes precedence. This is for special cases such > as within the framework library code, e.g. it doesn't make sense to > send `set height 0' with a timeout of 7200 seconds. This is a local > command that does not interact with the target and setting a high > timeout here only risks a test suite run taking ages if it goes astray > for some reason. > > 3. The fallback timeout of 60s remains. Maciej, IWBN to put the descriptions about timeout selection into the comments of proc gdb_expect. I don't see anything wrong in this patch. -- Yao (齐尧)