From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24071 invoked by alias); 24 Jul 2014 13:08:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24044 invoked by uid 89); 24 Jul 2014 13:08:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 24 Jul 2014 13:08:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6OD8GEl013447 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Jul 2014 09:08:17 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6OD8E79012314; Thu, 24 Jul 2014 09:08:15 -0400 Message-ID: <53D1053E.6030902@redhat.com> Date: Thu, 24 Jul 2014 13:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Doug Evans , Tom Tromey Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h References: <1406206287-6817-1-git-send-email-gbenson@redhat.com> <1406206287-6817-2-git-send-email-gbenson@redhat.com> In-Reply-To: <1406206287-6817-2-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00628.txt.bz2 On 07/24/2014 01:51 PM, Gary Benson wrote: > gdb/ > 2014-07-24 Tom Tromey > Gary Benson > > * common/errors.h: New file. > * common/errors.c: Likewise. > * Makefile.in (HFILES_NO_SRCDIR) [common/errors.h]: > New header. > (COMMON_OBS) [errors.o]: New object file. Write: (COMMON_OBS): Add errors.o. [] has a specific meaning that is not what you're doing here. See: https://www.gnu.org/prep/standards/html_node/Conditional-Changes.html#Conditional-Changes > (errors.o): New rule. > * utils.h: Include errors.h. > (perror_with_name, error, verror, warning, vwarning): > Don't declare. > * common/common-utils.h: Include errors.h. > (malloc_failure, internal_error): Don't declare. > > gdb/gdbserver/ > 2014-07-24 Tom Tromey > Gary Benson > > * Makefile.in (SFILES) [common/errors.c]: New sourcefile. > (OBS) [errors.o]: New object file. > (IPA_OBS) [errors-ipa.o]: Likewise. Likewise. > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include "config.h" Sorry for the push back, but it's wrong to only include "config.h". We need to include gnulib's config.h everywhere too. I think the best is to add a central common header that handles that detail first. -- Thanks, Pedro Alves