Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] fix to_open debug setting
Date: Thu, 24 Jul 2014 01:17:00 -0000	[thread overview]
Message-ID: <53D05C52.4060005@redhat.com> (raw)
In-Reply-To: <87d2cxs9bu.fsf@fleche.redhat.com>

On 07/22/2014 04:27 PM, Tom Tromey wrote:
> Tom> Later I happened to notice that add_deprecated_target_alias could use
> Tom> the same treatment.  I'll send the new patch tomorrow.
> 
> Here it is.

Looks good to me.

> +/* This is used to implement the various target commands.  */
> +
> +static void
> +open_target (char *args, int from_tty, struct cmd_list_element *command)
> +{
> +  struct target_ops *ops = get_cmd_context (command);
> +
> +  if (targetdebug)
> +    fprintf_unfiltered (gdb_stdlog, "target_open (%s, %d)\n", args, from_tty);

I think it'd be nice if this included the target's name, like your
generated debug methods.

Thanks,
-- 
Pedro Alves


  reply	other threads:[~2014-07-24  1:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 23:29 Tom Tromey
2014-07-22 13:10 ` Tom Tromey
2014-07-22 15:28   ` Tom Tromey
2014-07-24  1:17     ` Pedro Alves [this message]
2014-07-24 15:18       ` Tom Tromey
2014-07-24 15:21         ` Pedro Alves
2014-07-30 14:02         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D05C52.4060005@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox