From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6913 invoked by alias); 20 Jul 2014 00:56:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6756 invoked by uid 89); 20 Jul 2014 00:55:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a48.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a48.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Jul 2014 00:55:49 +0000 Received: from homiemail-a48.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a48.g.dreamhost.com (Postfix) with ESMTP id 73D524F805B; Sat, 19 Jul 2014 17:55:47 -0700 (PDT) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a48.g.dreamhost.com (Postfix) with ESMTPSA id 3C96A4F8057; Sat, 19 Jul 2014 17:55:47 -0700 (PDT) Message-ID: <53CB1392.4060206@eagerm.com> Date: Sun, 20 Jul 2014 12:57:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , Pedro Alves CC: "gdb-patches@sourceware.org" , Michael Eager , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Fix for remote G Packet message too long error for baremetal. References: <53A023B1.5000105@redhat.com> <859f27cb-8c46-46c1-9625-7287c60f3ae9@BY2FFO11FD007.protection.gbl> <53A1ABF0.9080004@redhat.com> <74281fd5-518a-4d7f-977a-6fa1320f6db9@BY2FFO11FD016.protection.gbl> <53A1B61F.9080803@redhat.com> <736c2e0d-6ff1-40c3-8120-dc6f5d91e6b1@BL2FFO11FD052.protection.gbl> <53A8290A.1050701@redhat.com> <53A94147.4050700@redhat.com> <57ebe4b0-83eb-4208-9778-472ecf0048d4@BY2FFO11FD038.protection.gbl> <53A96993.5040804@redhat.com> <109c35c1-e2f6-430f-9235-c6c82a93daf1@BL2FFO11FD009.protection.gbl> <53A97330.4080708@redhat.com> <53B1420A.40501@redhat.com> <53B1488B.7070007@redhat.com> <48d1f24b-3924-44d4-85e3-a25ae7012647@BY2FFO11FD048.protection.gbl> In-Reply-To: <48d1f24b-3924-44d4-85e3-a25ae7012647@BY2FFO11FD048.protection.gbl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00527.txt.bz2 On 07/01/14 12:36, Ajit Kumar Agarwal wrote: > Hello Pedro: > > Please find the updated patch. Incorporated review comments. > > [Patch, microblaze]: Fix for remote G Packet message too long error for baremetal. > > Prior to version MicroBlaze v8.10.a,EDK 13.1, XMD's gdbserver stub returned 57 > registers in response to GDB's G request. Starting with version MicroBlaze > v8.10.a, EDK 13.1, XMD added the slr and shr register, for a count of 59 > registers. This patch adds these registers to the expected G response. This patch > fixes the above problem for baremetal and also supports the backward compatibility. > > ChangeLog: > 2014-07-02 Ajit Agarwal > > * microblaze-tdep.c (microblaze_register_names): Add > the rshr and rslr register names. > (microblaze_gdbarch_init): Use of tdesc_has_registers. > Use of tdesc_find_feature. Use of tdesc_data_alloc. > Use of tdesc_numbered_register. Use of > microblaze_register_g_packet_guesses. Use of > tdesc_use_registers. Use of set_gdbarch_register_type. > (microblaze_register_g_packet_guesses): New. > * microblaze-tdep.h (microblaze_reg_num): Add > field MICROBLAZE_SLR_REGNUM MICROBLAZE_SHR_REGNUM > MICROBLAZE_NUM_REGS and MICROBLAZE_NUM_CORE_REGS. > (microblaze_frame_cache): Use of MICROBLAZE_NUM_REGS. > * features/microblaze-core.xml: New file. > * features/microblaze-stack-protect.xml: New file. > * features/microblaze-with-stack-protect.c: New file. > * features/microblaze-with-stack-protect.xml: New file. > * features/microblaze.xml: New file. > * features/microblaze.c: New file. > * features/Makefile (microblaze-with-stack-protect): Add > microblaze-with-stack-protect microblaze and > microblaze-expedite. > * regformats/microblaze-with-stack-protect.dat: New file. > * regformats/microblaze.dat: New file. > * doc/gdb.texinfo (MicroBlaze Features): New. ^^^ changed to Added. Patch has trailing whitespace. Committed 164224e9 without trailing whitespace. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077