From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16317 invoked by alias); 17 Jul 2014 16:12:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16302 invoked by uid 89); 17 Jul 2014 16:12:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 17 Jul 2014 16:12:11 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6HGC8Px015176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Jul 2014 12:12:08 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6HGC6I2014465; Thu, 17 Jul 2014 12:12:07 -0400 Message-ID: <53C7F5D6.6060102@redhat.com> Date: Thu, 17 Jul 2014 16:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson CC: Doug Evans , gdb-patches , Tom Tromey Subject: Re: [PATCH 01/15 v3] Introduce common/errors.h References: <1405520243-17282-1-git-send-email-gbenson@redhat.com> <1405520243-17282-2-git-send-email-gbenson@redhat.com> <20140717134728.GB31916@blade.nx> <53C7E6AB.4080703@redhat.com> <20140717153957.GA1921@blade.nx> In-Reply-To: <20140717153957.GA1921@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00472.txt.bz2 On 07/17/2014 04:39 PM, Gary Benson wrote: > Pedro Alves wrote: >> On 07/17/2014 02:47 PM, Gary Benson wrote: >>> +/* Throw an error. The current operation will be aborted. The >>> + message will be issued to the user. The application will >>> + return to a state where it is accepting commands from the user. */ >> >> These comments aren't really true, though. We have plenty of places >> catching errors with TRY_CATCH and proceeding without returning to a >> state where we're accepting commands from the user. > > How about "Throw an error. The current operation will be aborted. > The application may catch and process the error, or, if not, the > message will be issued to the user and the application will return > to a state where it is accepting commands from the user." Still infers what the application does with the error. IMO, it's best to describe the interface. Like: Throw a generic error. This function not return, instead it executes a long jump, aborting the current operation. The function takes printf-style arguments, which are used to construct the error message. >> (We should really bite the bullet and move exceptions.{h|c} and >> cleanups.{h|c} to common/ and make gdbserver use them too.) > > Can I leave this for another series please? This one's big enough > already. Yes, of course. That's why it was a parenthesis. -- Pedro Alves