From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22275 invoked by alias); 15 Jul 2014 15:44:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22256 invoked by uid 89); 15 Jul 2014 15:44:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 15 Jul 2014 15:44:50 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id ED.01.25146.477F4C35; Tue, 15 Jul 2014 11:42:12 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.93) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 15 Jul 2014 11:44:46 -0400 Message-ID: <53C54C6E.40607@ericsson.com> Date: Tue, 15 Jul 2014 15:45:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PUSHED] Handle OP_STRING in dump_subexp_body_standard References: <1405437917-1170-1-git-send-email-simon.marchi@ericsson.com> <20140715154254.GH4888@adacore.com> In-Reply-To: <20140715154254.GH4888@adacore.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00393.txt.bz2 On 14-07-15 11:42 AM, Joel Brobecker wrote: >> (gdb) set debug expression 1 >> (gdb) print "hello" >> ... (random garbage, possibly segfault) > [...] >> 2014-07-15 Simon Marchi >> >> * expprint.c (dump_subexp_body_standard): Handle OP_STRING. > > I forgot something! Do you think you could add a test for that? > It should be fairly straightforward to add one, I think. Oh, indeed. That would go in gdb.base/debug-expr.exp I presume.