From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4439 invoked by alias); 15 Jul 2014 09:37:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4423 invoked by uid 89); 15 Jul 2014 09:37:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Jul 2014 09:37:32 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6F9bRrA013947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Jul 2014 05:37:27 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6F9bPGo028781; Tue, 15 Jul 2014 05:37:26 -0400 Message-ID: <53C4F655.2040708@redhat.com> Date: Tue, 15 Jul 2014 09:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Doug Evans CC: Jan Kratochvil , eliz@gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Re: Regression for GDB global --statistics References: <20140630171333.GA2225@host2.jankratochvil.net> <21437.45024.997531.453750@ruffy.mtv.corp.google.com> <53BEC275.8000004@redhat.com> <21440.24455.769287.540494@ruffy.mtv.corp.google.com> In-Reply-To: <21440.24455.769287.540494@ruffy.mtv.corp.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00363.txt.bz2 On 07/11/2014 11:04 PM, Doug Evans wrote: > Pedro Alves writes: > > It's not obvious to me how this can be NULL, given we initialize > > it so early. If there's a good reason, could you please add > > a comment here mentioning it? ... > - ALL_SYMTABS (o, s) > + /* When collecting statistics during startup, this is called before > + pretty much anything in gdb has been initialized, and thus > + current_program_space may be NULL. */ > + if (current_program_space != NULL) Great, thanks! -- Pedro Alves