From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23067 invoked by alias); 11 Jul 2014 19:57:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23014 invoked by uid 89); 11 Jul 2014 19:57:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: qmta15.emeryville.ca.mail.comcast.net Received: from qmta15.emeryville.ca.mail.comcast.net (HELO qmta15.emeryville.ca.mail.comcast.net) (76.96.27.228) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Jul 2014 19:57:52 +0000 Received: from omta18.emeryville.ca.mail.comcast.net ([76.96.30.74]) by qmta15.emeryville.ca.mail.comcast.net with comcast id R7j01o0051bwxycAF7xrvX; Fri, 11 Jul 2014 19:57:51 +0000 Received: from redwood.eagercon.com ([24.7.16.38]) by omta18.emeryville.ca.mail.comcast.net with comcast id R7xp1o00K0pGQcg8e7xqKU; Fri, 11 Jul 2014 19:57:50 +0000 Message-ID: <53C041BD.4060303@eagercon.com> Date: Fri, 11 Jul 2014 20:58:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , Joel Brobecker CC: "gdb-patches@sourceware.org" , Pedro Alves , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Add support of microblaze software single stepping References: <20140707145634.GF6038@adacore.com> <35bccb81-cae6-4581-b5fd-16dea7171d28@BN1AFFO11FD012.protection.gbl> <20140711135114.GA4888@adacore.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00294.txt.bz2 On 07/11/14 12:34, Ajit Kumar Agarwal wrote: > >>> Please also explain how this patch was tested. > > The changes were tested with the application for barematel with remote debug with XMD debugger( internal to Xilinx)which connects to the target and opens the gdbserver connection. Single stepping command were used for next_pc in straight line code, with imm instruction and the branch with delay Slot. Your terminology may be a bit confusing. Gdbserver is a program (part of GDB) which runs on a platform (e.g. Linux), and which implements the GDB Remote Serial Protocol. XMD does not run gdbserver. It has an independent implementation of the GDB Remote Serial Protocol. It would be better to say that XMD is a remote stub. Please provide a disassembly of the test case and a log of the commands to gdb and gdb's output, showing stepping over imm and delay slot instructions. Is there a test case which shows single stepping failing without the patch? Even better would be to update the gdb regression test suite with the test case. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077