From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23027 invoked by alias); 9 Jul 2014 18:23:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23014 invoked by uid 89); 9 Jul 2014 18:23:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Jul 2014 18:23:55 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1X4wX2-0006Hp-E2 from donb@codesourcery.com ; Wed, 09 Jul 2014 11:23:52 -0700 Received: from [127.0.0.1] ([172.30.7.155]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 9 Jul 2014 11:23:52 -0700 Message-ID: <53BD88B7.4020100@codesourcery.com> Date: Wed, 09 Jul 2014 18:23:00 -0000 From: "Breazeal, Don" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson CC: gdb-patches@sourceware.org Subject: Re: [PATCH 02/15] Remove some GDBSERVER checks from linux-ptrace References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-3-git-send-email-gbenson@redhat.com> <53BD7B6C.8030205@codesourcery.com> <20140709182016.GA17984@blade.nx> In-Reply-To: <20140709182016.GA17984@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00196.txt.bz2 On 7/9/2014 11:20 AM, Gary Benson wrote: > Breazeal, Don wrote: >> On 7/9/2014 3:37 AM, Gary Benson wrote: >>> This patch removes some GDBSERVER checks from nat/linux-ptrace.c. >>> Currently the code uses a compile-time check to decide whether >>> some flags should be used. This changes the code to instead let >>> users of the module specify an additional set of flags; and then >>> changes gdb's linux-nat.c to call this function. At some later >>> date, when the back ends are fully merged, we will be able to >>> remove this function again. >> >> I just want to point out that I'm doing something similar as part >> of my work on follow-fork for extended remote, based on Tom's >> suggestion here: >> >> https://sourceware.org/ml/gdb-patches/2014-05/msg00486.html >> >> In my case it adds "base" options and the capability to set the >> ptrace options to the "additional" options at the caller's >> discretion, such as when gdbserver receives the enable-extended-mode >> packet. So, no objection, just wanted to let you know that I hope >> to submit somewhat different changes to the same code soon. > > The patch I posted is basically an updated version of the patch Tom > posted there--the only change IIRC is that linux-ptrace.c is now in > "nat" rather than "common". > > Do you need me to change anything about this parch, or is it ok for > you to work with? It is OK for me. thanks --Don > > Thanks, > Gary >