From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9636 invoked by alias); 9 Jul 2014 14:52:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9612 invoked by uid 89); 9 Jul 2014 14:52:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Jul 2014 14:52:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s69Eq2Q2005804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jul 2014 10:52:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s69Eq0Ng017596; Wed, 9 Jul 2014 10:52:01 -0400 Message-ID: <53BD5710.5040105@redhat.com> Date: Wed, 09 Jul 2014 14:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Tweak gdb.trace/tfile.c for thumb mode References: <1404100222-2312-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1404100222-2312-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00189.txt.bz2 On 06/30/2014 04:50 AM, Yao Qi wrote: > + /* Although the thumb functions are two-bytes aligned, ld sets the > + bit 0 of these function references. Clear the bit 0. */ > +#if defined(__thumb__) || defined(__thumb2__) > + func_addr &= ~1; > +#endif I suggest putting the comment within the #if block, and write: #if defined(__thumb__) || defined(__thumb2__) /* Although Thumb functions are two-byte aligned, function pointers have the Thumb bit set. Clear it. */ func_addr &= ~1; #endif (This bit is widely known as the "Thumb bit", so call it that, and remove a few "the"'s that sound odd to me, and say "two-byte aligned".) Otherwise looks good. Thanks, -- Pedro Alves