From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30094 invoked by alias); 9 Jul 2014 13:13:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30080 invoked by uid 89); 9 Jul 2014 13:13:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Jul 2014 13:13:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s69DDfwZ016026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jul 2014 09:13:41 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s69DDdNv025441; Wed, 9 Jul 2014 09:13:39 -0400 Message-ID: <53BD4002.6040002@redhat.com> Date: Wed, 09 Jul 2014 13:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Mark Kettenis Subject: Re: [PATCH 7/7 v2] Tidy #include lists References: <1403878351-22974-1-git-send-email-gbenson@redhat.com> <1403878351-22974-8-git-send-email-gbenson@redhat.com> In-Reply-To: <1403878351-22974-8-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00185.txt.bz2 On 06/27/2014 03:12 PM, Gary Benson wrote: > This commit tidies up the #include lists in {i386,amd64}-linux-nat.c, > removing headers that are no longer required and reordering some lines > so that both files roughly match. Additionally, an unused definition > was removed from the middle of the #include list in i386-linux-nat.c. > > This patch is unchanged from the original version in this series. > > gdb/ > 2014-06-27 Gary Benson > > * amd64-linux-nat.c (gdbcore.h): Removed include. ... > (ORIG_EAX): Removed definition. ... Nit, it's more standard to use the imperative, "Remove". Looks good to me. Thanks, -- Pedro Alves