From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27468 invoked by alias); 9 Jul 2014 13:12:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27447 invoked by uid 89); 9 Jul 2014 13:12:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Jul 2014 13:12:30 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s69DCT4W014221 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Jul 2014 09:12:29 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s69DCRQD016284; Wed, 9 Jul 2014 09:12:28 -0400 Message-ID: <53BD3FBB.9070208@redhat.com> Date: Wed, 09 Jul 2014 13:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Mark Kettenis Subject: Re: [PATCH 6/7 v2] Move duplicated code into new files References: <1403878351-22974-1-git-send-email-gbenson@redhat.com> <1403878351-22974-7-git-send-email-gbenson@redhat.com> In-Reply-To: <1403878351-22974-7-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-07/txt/msg00184.txt.bz2 On 06/27/2014 03:12 PM, Gary Benson wrote: > This commit moves the shared code in {i386,amd64}-linux-nat.c Nit: s/shared/identical/. It's only shared afterwards. > into the new files x86-linux-nat.[ch]. Additionally, a new > file i386-linux-nat.h was required to expose a value required > by the 32-bit code in x86-linux-nat.c. > > This patch differs from the original version in this series > in that x86_linux_read_description has been rewritten in an > earlier patch. > (x86_linux_dr_get_addr): Likewise. > (x86_linux_dr_get_control) Likewise.: Typo, ':' position. > (x86_linux_dr_get_status): Likewise. Otherwise looks good to me. Thanks, -- Pedro Alves