From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19684 invoked by alias); 9 Jul 2014 13:07:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19674 invoked by uid 89); 9 Jul 2014 13:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f173.google.com Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 09 Jul 2014 13:07:40 +0000 Received: by mail-wi0-f173.google.com with SMTP id cc10so2724223wib.12 for ; Wed, 09 Jul 2014 06:07:37 -0700 (PDT) X-Received: by 10.180.93.196 with SMTP id cw4mr11222487wib.69.1404911257498; Wed, 09 Jul 2014 06:07:37 -0700 (PDT) Received: from [192.168.0.102] (bl16-23-176.dsl.telepac.pt. [188.81.23.176]) by mx.google.com with ESMTPSA id de5sm19254629wib.18.2014.07.09.06.07.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Jul 2014 06:07:36 -0700 (PDT) Message-ID: <53BD3E96.2070602@gmail.com> Date: Wed, 09 Jul 2014 13:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Mark Kettenis , Pedro Alves Subject: Re: [PATCH 2/7 v2] Merge {i386,amd64}_linux_read_description References: <1403878351-22974-1-git-send-email-gbenson@redhat.com> <1403878351-22974-3-git-send-email-gbenson@redhat.com> In-Reply-To: <1403878351-22974-3-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00179.txt.bz2 On 06/27/2014 03:12 PM, Gary Benson wrote: > This commit merges i386_ and amd64_linux_read_description, renaming > both to x86_linux_read_description. > > This patch differs from the original version in this series > in that x86_linux_read_description is much cleaner, having > been rewritten to avoid "#ifdef spaghetti". > > gdb/ > 2014-06-27 Gary Benson > > * amd64-linux-nat.c (amd64_linux_read_description): Renamed to > x86_linux_read_description. All uses updated. amd64-specific > code conditionalized. Conditionalized i386-specific code added. > Redundant cast removed. > * i386-linux-nat.c (i386_linux_read_description): Renamed to > x86_linux_read_description. All uses updated. i386-specific > code conditionalized. Conditionalized amd64-specific code added. > One sizeof replaced with the actual type it is describing. I compared the old vs new files side by side to try to check that the merged code behaved the same the as before. This version does look much cleaner. Looks good to me, thanks. -- Pedro Alves