From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28928 invoked by alias); 26 Jun 2014 14:15:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28895 invoked by uid 89); 26 Jun 2014 14:15:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Jun 2014 14:15:09 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5QEF4KQ007297 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Jun 2014 10:15:04 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5QEF2Ut011414; Thu, 26 Jun 2014 10:15:03 -0400 Message-ID: <53AC2AE6.7060401@redhat.com> Date: Thu, 26 Jun 2014 14:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Andreas Arnez CC: gdb-patches@sourceware.org Subject: Re: [PATCH] watchpoint-reuse-slot.exp: Correctly skip unsupported commands. References: <87pphvhj6i.fsf@br87z6lw.de.ibm.com> In-Reply-To: <87pphvhj6i.fsf@br87z6lw.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00909.txt.bz2 On 06/26/2014 02:52 PM, Andreas Arnez wrote: > The test case "watchpoint-reuse-slot.exp" yields a lot of failures on > s390/s390x: all instances of awatch, rwatch, and hbreak are performed > even though they aren't supported on these targets. This is because > the test case ignores non-support error messages when probing for > support of these commands, like: > > (gdb) rwatch buf.byte[0] > Target does not support this type of hardware watchpoint. > > The patch adds handling for this case in the appropriate > gdb_test_multiple invocations. Thank you. Looks like I only hacked out target_insert_watchpoint/hw_breakpoint in my testing to return unsupported, which is what leads to the "You may have requested too many" regexs in place: (top-gdb) awatch args.argc Hardware access (read/write) watchpoint 4: args.argc Warning: Could not insert hardware watchpoint 4. Could not insert hardware breakpoints: You may have requested too many hardware breakpoints/watchpoints. We get that that error too when debugging against gdbserver with Z packets disabled, which I also tested. We get that alternative error if the target_can_use_hw_breakpoint method returns false, which I forgot to hack/test. > > gdb/testsuite/ > * gdb.base/watchpoint-reuse-slot.exp: Handle the case that the > target lacks support for watch, awatch, rwatch, or hbreak. s/watch, // , I think, as "watch" falls back to software watchpoints. Patch is OK. Thanks! -- Pedro Alves