From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] constify search_symbols
Date: Tue, 24 Jun 2014 13:44:00 -0000 [thread overview]
Message-ID: <53A98054.5000803@codesourcery.com> (raw)
In-Reply-To: <87mwd24f9j.fsf@fleche.redhat.com>
On 06/24/2014 09:18 PM, Tom Tromey wrote:
>>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>
> Yao> file_name isn't used out side of this block, so we can define file_name
> Yao> within this block of type "char *", and patch can be shorter.
>
> The problem is that we need to set "file_names = &file_name", and you
> can't take the address of a "char *" and cast that to "const char **".
>
Ah. You are right. Compiler complains on this statement "files =
&file_name". I have no comments on this patch then.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-06-24 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 17:24 Tom Tromey
2014-06-24 3:11 ` Yao Qi
2014-06-24 13:18 ` Tom Tromey
2014-06-24 13:44 ` Yao Qi [this message]
2014-06-30 14:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A98054.5000803@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox