From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18965 invoked by alias); 24 Jun 2014 13:19:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18956 invoked by uid 89); 24 Jun 2014 13:19:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 Jun 2014 13:19:54 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5ODJpCp017787 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Jun 2014 09:19:51 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5ODJo7q032240; Tue, 24 Jun 2014 09:19:50 -0400 Message-ID: <53A97AF5.3020804@redhat.com> Date: Tue, 24 Jun 2014 13:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/3] btrace: pretend we're not replaying when generating a core file References: <1403599872-25299-1-git-send-email-markus.t.metzger@intel.com> <1403599872-25299-3-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1403599872-25299-3-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00850.txt.bz2 Hi Markus, On 06/24/2014 09:51 AM, Markus Metzger wrote: > When generating a core file using the "generate-core-file" command while > replaying with the btrace record target, we won't be able to access all > registers and all memory. This leads to an assertion. Please paste the gdb output showing the assertion in question here in the commit log for future reference. > Pretend that we are not replaying while generating a core file. This will > forward fetch and store registers as well as xfer memory calls to the target > beneath. > > +/* The to_prepare_to_generate_core target method. */ > + > +static void > +record_btrace_prepare_to_generate_core (struct target_ops *self) > +{ > + record_btrace_generating_corefile = 1; > +} > + > +/* The to_done_generating_core target method. */ > + > +static void > +record_btrace_done_generating_core (struct target_ops *self) > +{ > + record_btrace_generating_corefile = 0; This flag should also be cleared in record_btrace_open, in case the target was previously abruptly closed between the record_btrace_prepare_to_generate_core and record_btrace_done_generating_core calls. OK with that change. Thank you. -- Pedro Alves