From: Pedro Alves <palves@redhat.com>
To: Mingjie Xing <mingjie.xing@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [patch] Share options between info and man page
Date: Mon, 23 Jun 2014 13:45:00 -0000 [thread overview]
Message-ID: <53A82F8B.7080507@redhat.com> (raw)
In-Reply-To: <CADNgcEwURN4xMTdMxqhb_poZ=mttgD5FmDNBeezumQgsagaUMw@mail.gmail.com>
On 06/12/2014 04:35 AM, Mingjie Xing wrote:
> Hi Pedro, thank you for the careful checking. See the attachment for
> the new patch and the diff result. Following my comment,
>
> 2014-06-11 19:39 GMT+08:00 Pedro Alves <palves@redhat.com>:
>> On 06/10/2014 06:56 PM, Eli Zaretskii wrote:
>>
>>> Thanks. This looks good to me. If no one objects, it should go in
>>> soon.
>>
>> I applied the patch locally, and noticed some things misrendered in the
>> new man page, like, options are now listed with double quotes instead
>> of being highlighted. E.g.:
>>
>> "-help"
>> "-h"
>
> This is because the previous man page uses "@table @env" while the
> current Invoke sections uses "@table @code". I've fixed.
>
>> This one is preexisting, but note "C@t{++}" in:
>>
>> "You can use GDB to debug programs written in C, C@t{++}, Fortran and Modula-2."
>
> This seems that texi2pod is unable to handle "@t". The problem also
> occurs for the old man page if you build from the current git.
But then we lose formatting on the info pages, right?
Should we re-define it as a macro under ifset man ?
@ifset man
@macro t{text}
\text\
@end macro
@end ifset
(I don't actually know whether possible.)
>
>> This sentence seems to be out of place:
>>
>> "You can run GDB in various alternative modes---for example, in batch mode or quiet mode."
>
> OK, I've put it out.
>
>> Not sure, but "---" might be misrendered too.
>
> Hmm, there are many such usage (no space before/afert "--") in gdb.texinfo.
Those three dashes are rendered as an em dash in texinfo:
http://www.gnu.org/software/texinfo/manual/texinfo/html_node/Conventions.html
I'd assume the man page should end up with \(em instead of literal ---.
Should we have a macro for this too?
>
>> This incomplete sentence appears, seemingly trying to refer to a chapter
>> in the manual:
>>
>> " For further documentation on startup processing, For documentation on how to write command files,"
>
> Yes, still seems texi2pod's problem, which simply through away the
> content for @xref/@pxref. I've changed ", @xref" to ", see @ref" to
> correctly display them in man page.
>
> Note, that current doc uses @xref after a comma, which is incorrect.
>
>> At this point, I generated a diff of the old/new man pages, in plain text, with:
>>
>> $ man ./gdb.1 > gdb.1.txt
>> $ man ./gdb.1.new > gdb.1.new.txt
>> $ diff -up gdb.1.txt gdb.1.new.txt
>>
>> I think that's helpful to review this. The result is below. Seems there are
>> other odd things in there, like "GDB/MI INTERFACE" in all caps?
>
> Still texi2pod's problem. It can't handle correctly the nested form
> "@dfn{@sc{gdb/mi} interface}". This can be fix by reorder the process
> sequence. Move
>
> s/\@sc\{([^\}]*)\}/\U$1/g;
>
> before
>
> s/\@(?:dfn|var|emph|cite|i)\{([^\}]*)\}/I<$1>/g;
>
> But, what if @sc{@dfn{...}}?
Hopefully Eli can take a new look. The new resulting output diff
looks much better to me now. Thanks for doing this.
--
Pedro Alves
next prev parent reply other threads:[~2014-06-23 13:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 8:40 Mingjie Xing
2014-06-09 14:52 ` Eli Zaretskii
2014-06-10 0:46 ` Mingjie Xing
2014-06-10 2:52 ` Eli Zaretskii
2014-06-10 7:00 ` Mingjie Xing
2014-06-10 7:03 ` Mingjie Xing
2014-06-10 17:56 ` Eli Zaretskii
2014-06-11 11:39 ` Pedro Alves
2014-06-12 3:36 ` Mingjie Xing
2014-06-23 13:45 ` Pedro Alves [this message]
2014-06-24 7:08 ` Mingjie Xing
2014-06-24 15:56 ` Eli Zaretskii
2014-06-25 1:30 ` Mingjie Xing
2014-06-26 9:34 ` Mingjie Xing
2014-07-07 1:12 ` Mingjie Xing
2014-07-07 14:18 ` Joel Brobecker
2014-07-07 15:26 ` Eli Zaretskii
2014-07-07 15:31 ` Joel Brobecker
2014-07-08 9:47 ` Pedro Alves
2014-07-08 14:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A82F8B.7080507@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mingjie.xing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox