From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24946 invoked by alias); 21 Jun 2014 23:19:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24926 invoked by uid 89); 21 Jun 2014 23:19:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mpv2.tis.cwru.edu Received: from mpv2.tis.CWRU.Edu (HELO mpv2.tis.cwru.edu) (129.22.105.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Sat, 21 Jun 2014 23:19:17 +0000 Received: from mpv8.tis.CWRU.Edu (EHLO mpv8.cwru.edu) ([129.22.105.116]) by mpv2.tis.cwru.edu (MOS 4.3.5-GA FastPath queued) with ESMTP id BGE69704; Sat, 21 Jun 2014 19:19:14 -0400 (EDT) Received: from h0.82.16.98.dynamic.ip.windstream.net (EHLO _192.168.254.10_) ([98.16.82.0]) by mpv8.cwru.edu (MOS 4.3.5-GA FastPath queued) with ESMTP id LJJ08593 (AUTH cpr); Sat, 21 Jun 2014 19:19:13 -0400 (EDT) Message-ID: <53A612EF.9070400@case.edu> Date: Sat, 21 Jun 2014 23:19:00 -0000 From: Chet Ramey Reply-To: chet.ramey@case.edu User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Chen Gang CC: chet.ramey@case.edu, Andreas Schwab , palves@redhat.com, gdb-patches@sourceware.org, binutils@sourceware.org, bug-readline@gnu.org, amodra@gmail.com Subject: Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file() References: <5397C077.1080702@gmail.com> <53A1F78A.8020508@case.edu> <53A23D77.1040905@gmail.com> <53A3F78E.6020803@gmail.com> <53A4AD62.6020408@case.edu> <53A4ED1B.2060608@gmail.com> In-Reply-To: <53A4ED1B.2060608@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Junkmail-Whitelist: YES (by domain whitelist at mpv2.tis.cwru.edu) X-SW-Source: 2014-06/txt/msg00792.txt.bz2 On 6/20/14, 10:25 PM, Chen Gang wrote: >> There aren't really any plausible conditions under which write(2) returns >> 0 instead of -1 when writing a non-zero number of bytes to a regular file. >> > > Hmm... for me, what you said is acceptable. And the function comment need be > changed: > > "Returns 0 on success, errno or -1 on failure" history_truncate_file will never return -1. > And since you will work for it next, is it still necessary to send patch v2 for > the temporary fix, at present? I will take care of making those changes, thanks. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/