From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15472 invoked by alias); 18 Jun 2014 13:55:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15462 invoked by uid 89); 18 Jun 2014 13:55:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Jun 2014 13:55:38 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5IDtZIq025363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Jun 2014 09:55:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5IDtWmd003789; Wed, 18 Jun 2014 09:55:33 -0400 Message-ID: <53A19A53.6030107@redhat.com> Date: Wed, 18 Jun 2014 13:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Gary Benson , Siva Chandra , Pedro Alves CC: gdb-patches Subject: Re: [PATCH 11/15] Rename functions and make nonstatic as necessary References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-12-git-send-email-gbenson@redhat.com> <20140618132832.GA6225@blade.nx> In-Reply-To: <20140618132832.GA6225@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00657.txt.bz2 On 06/18/2014 02:28 PM, Gary Benson wrote: > Siva Chandra wrote: >> On Tue, Jun 17, 2014 at 7:12 AM, Gary Benson wrote: >>> This commit renames the functions that are to be shared. >>> Functions to be shared that were static are made nonstatic. >> >> I thinking making the functions nonstatic in this part was not >> correct. The build currently fails when built with >> "-Werror=missing-prototypes" as 14/15 has not yet been committed. > > My apologies Siva. > > Pedro, should I commit the remaining piece now, and work on the > i386_insert_hw_breakpoint as a separate patch? As you've committed the header patch already, I think the issue is actually already fixed? -- Pedro Alves