Re: [PATCH 14/15] Create nat/i386-dregs.c

Gary Benson
2014-06-18T13:43:05Z

Pedro Alves wrote:
> Hmm, there's still one remaining difference in gdb vs gdbserver,
> after this, in hw breakpoints.
>
> i386_insert_hw_breakpoint and i386_remove_hw_breakpoint on
> the GDB side still have the "work on a local copy"
> bits, and the i386_dr_update_inferior_debug_regs and
> i386_dr_show calls:
[snip]
>
> While on the gdbserver side, we just call i386_dr_insert_watchpoint:
[snip]

> Any reason GDB can't do the same?

Very good spot!

I'll work on this. It also allows a bunch of those static calls to be
reverted back to nonstatic. I like that (they made the exported
interface of i386-dregs ugly!)

I will work on a series to do this.

Thanks,
Gary

--