Re: [PATCH 11/15] Rename functions and make nonstatic as necessary

Siva Chandra
2014-06-18T14:03:53Z

On Wed, Jun 18, 2014 at 6:55 AM, Pedro Alves <palves@redhat.com> wrote:
> On 06/18/2014 02:28 PM, Gary Benson wrote:
>> Siva Chandra wrote:
>>> On Tue, Jun 17, 2014 at 7:12 AM, Gary Benson <gbenson@redhat.com> wrote:
>>>> This commit renames the functions that are to be shared.
>>>> Functions to be shared that were static are made nonstatic.
>>>
>>> I thinking making the functions nonstatic in this part was not
>>> correct. The build currently fails when built with
>>> "-Werror=missing-prototypes" as 14/15 has not yet been committed.
>>
>> My apologies Siva.
>>
>> Pedro, should I commit the remaining piece now, and work on the
>> i386_insert_hw_breakpoint as a separate patch?
>
> As you've committed the header patch already, I think the issue
> is actually already fixed?

Yes, I just checked; the issue is already fixed.