From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14194 invoked by alias); 17 Jun 2014 17:00:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14136 invoked by uid 89); 17 Jun 2014 17:00:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 17:00:51 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HH0nBl010457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 17 Jun 2014 13:00:49 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HH0mfo015431; Tue, 17 Jun 2014 13:00:48 -0400 Message-ID: <53A0743F.6010403@redhat.com> Date: Tue, 17 Jun 2014 17:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 00/15] Refactor shared code in i386-{nat,low}.[ch] References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1403014378-4349-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00627.txt.bz2 On 06/17/2014 03:12 PM, Gary Benson wrote: > Hi all, > > This series refactors the shared code in i386-{nat,low}.[ch] into > a pair of new files, nat/i386-dregs.[ch]. The patches are in two > groups. Group 1 removes the changes between the various files so > that the code to be shared is identical: > > 1/15 - Whitespace changes > 2/15 - Remove unnecessary prototypes > 3/15 - Remove unused macro > 4/15 - Comment changes > 5/15 - Add a const > 6/15 - Merge printing code > 7/15 - Merge error handling > 8/15 - Rename maint_show_dr to debug_hw_points > 9/15 - Merge i386_update_inferior_debug_regs > 10/15 - Abstract i386_dr_low access > > Group 2 moves all that identical code into the new files: > > 11/15 - Rename functions and make nonstatic as necessary > 12/15 - Create nat/i386-dregs.h > 13/15 - Move macros from i386-{nat,low}.c to i386-{nat,low}.h > 14/15 - Create nat/i386-dregs.c > 15/15 - Buildsystem changes > > Is this ok to commit? Excellent work. Almost all of it is OK to commit immediately. Feel free to push those in, and send the parts that need updating as a smaller v2 (I think patches 12-15) (that is, no need to keep carrying and reposting all the preparatory patches that are already good). Thanks! -- Pedro Alves