From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7097 invoked by alias); 17 Jun 2014 16:54:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7088 invoked by uid 89); 17 Jun 2014 16:54:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 16:54:52 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HGsoOp032647 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 17 Jun 2014 12:54:51 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HGsnY1009613; Tue, 17 Jun 2014 12:54:50 -0400 Message-ID: <53A072D9.5010802@redhat.com> Date: Tue, 17 Jun 2014 16:54:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 13/15] Move macros from i386-{nat,low}.c to i386-{nat,low}.h References: <1403014378-4349-1-git-send-email-gbenson@redhat.com> <1403014378-4349-14-git-send-email-gbenson@redhat.com> In-Reply-To: <1403014378-4349-14-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00625.txt.bz2 On 06/17/2014 03:12 PM, Gary Benson wrote: > This commit moves macros required by the soon-to-be-created > nat/i386-dregs.c into i386-{nat,low}.h. To get rid of the remaining '#ifdef GDBSERVER's in the new i386-dregs.c, we could make gdbserver use the i386_dr_low vector too. Did you look into that? Meanwhile, this is already much better than what we have today. Thus, this is OK. Thanks, -- Pedro Alves