From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15226 invoked by alias); 17 Jun 2014 16:34:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15214 invoked by uid 89); 17 Jun 2014 16:34:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 16:34:36 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HGYXO8006463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jun 2014 12:34:33 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HGYUMQ001165; Tue, 17 Jun 2014 12:34:31 -0400 Message-ID: <53A06E16.2020603@redhat.com> Date: Tue, 17 Jun 2014 16:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Pedro Alves , Ajit Kumar Agarwal , "gdb-patches@sourceware.org" CC: Michael Eager , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch, microblaze]: Communicate in larger blocks with the target. References: <41df2189-0a72-4543-ba31-297f81e663d7@BN1AFFO11FD025.protection.gbl> <53A04753.5010102@redhat.com> In-Reply-To: <53A04753.5010102@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00617.txt.bz2 On 06/17/2014 02:49 PM, Pedro Alves wrote: > On 06/17/2014 10:03 AM, Ajit Kumar Agarwal wrote: >> Please find the following patch. >> >> [Patch, microblaze]: Communicate in larger blocks with the target. >> >> Communicate in larger blocks with the target. The chunk of memory >> will be read from the target and then used in microblaze_analyze_prologue. >> The above process minimizes the transaction with the Debug Agent. > > We have core infrustructure for this now, in the form of a > code cache that reads ahead. Could you try using it? > All you have to do is replace target_read_memory calls that are > actually reading code, with target_read_code calls. See i386-tdep.c > for example. To be clear, I'm not talking about changing the new calls in your patch, but instead, to change the existing calls. Then your patch won't be necessary. -- Pedro Alves