Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 11/15] Rename functions and make nonstatic as necessary
Date: Tue, 17 Jun 2014 16:13:00 -0000	[thread overview]
Message-ID: <53A06911.1030801@redhat.com> (raw)
In-Reply-To: <1403014378-4349-12-git-send-email-gbenson@redhat.com>

On 06/17/2014 03:12 PM, Gary Benson wrote:
> This commit renames the functions that are to be shared.
> Functions to be shared that were static are made nonstatic.
> 
> gdb/
> 2014-06-17  Gary Benson  <gbenson@redhat.com>
> 
> 	* i386-nat.c (i386_show_dr): Renamed to
> 	i386_dr_show and made nonstatic.  All uses updated.
> 	(i386_length_and_rw_bits): Renamed to
> 	i386_dr_length_and_rw_bits and made nonstatic.
> 	All uses updated.
> 	(i386_insert_aligned_watchpoint): Renamed to
> 	i386_dr_insert_aligned_watchpoint and made nonstatic.
> 	All uses updated.
> 	(i386_remove_aligned_watchpoint): Renamed to
> 	i386_dr_remove_aligned_watchpoint and made nonstatic.
> 	All uses updated.
> 	(i386_update_inferior_debug_regs): Renamed to
> 	i386_dr_update_inferior_debug_regs and made nonstatic.
> 	All uses updated.
> 
> gdb/gdbserver/
> 2014-06-17  Gary Benson  <gbenson@redhat.com>
> 
> 	* i386-low.h (i386_low_insert_watchpoint): Renamed to
> 	i386_dr_insert_watchpoint.
> 	(i386_low_remove_watchpoint): Renamed to
> 	i386_dr_remove_watchpoint.
> 	(i386_low_region_ok_for_watchpoint): Renamed to
> 	i386_dr_region_ok_for_watchpoint.
> 	(i386_low_stopped_data_address): Renamed to
> 	i386_dr_stopped_data_address.
> 	(i386_low_stopped_by_watchpoint): Renamed to
> 	i386_dr_stopped_by_watchpoint.
> 	* i386-low.c (i386_show_dr): Renamed to
> 	i386_dr_show and made nonstatic.  All uses updated.
> 	(i386_length_and_rw_bits): Renamed to
> 	i386_dr_length_and_rw_bits and made nonstatic.
> 	All uses updated.
> 	(i386_insert_aligned_watchpoint): Renamed to
> 	i386_dr_insert_aligned_watchpoint and made nonstatic.
> 	All uses updated.
> 	(i386_remove_aligned_watchpoint): Renamed to
> 	i386_dr_remove_aligned_watchpoint and made nonstatic.
> 	All uses updated.
> 	(i386_update_inferior_debug_regs): Renamed to
> 	i386_dr_update_inferior_debug_regs and made nonstatic.
> 	All uses updated.
> 	(i386_low_insert_watchpoint): Renamed to
> 	i386_dr_insert_watchpoint.  All uses updated.
> 	(i386_low_remove_watchpoint): Renamed to
> 	i386_dr_remove_watchpoint.  All uses updated.
> 	(i386_low_region_ok_for_watchpoint): Renamed to
> 	i386_dr_region_ok_for_watchpoint.  All uses updated.
> 	(i386_low_stopped_data_address): Renamed to
> 	i386_dr_stopped_data_address.  All uses updated.
> 	(i386_low_stopped_by_watchpoint): Renamed to
> 	i386_dr_stopped_by_watchpoint.  All uses updated.


Most excellent.  OK.

Thanks,
-- 
Pedro Alves


  reply	other threads:[~2014-06-17 16:13 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 14:13 [PATCH 00/15] Refactor shared code in i386-{nat,low}.[ch] Gary Benson
2014-06-17 14:13 ` [PATCH 03/15] Remove unused macro Gary Benson
2014-06-17 15:35   ` Pedro Alves
2014-06-17 14:13 ` [PATCH 01/15] Whitespace changes Gary Benson
2014-06-17 15:23   ` Pedro Alves
2014-06-17 14:13 ` [PATCH 04/15] Comment changes Gary Benson
2014-06-17 15:45   ` Pedro Alves
2014-06-17 16:10     ` Gary Benson
2014-06-17 17:11       ` Pedro Alves
2014-06-17 14:40 ` [PATCH 06/15] Merge printing code Gary Benson
2014-06-17 16:01   ` Pedro Alves
2014-06-17 14:40 ` [PATCH 14/15] Create nat/i386-dregs.c Gary Benson
2014-06-17 16:56   ` Pedro Alves
2014-06-18 13:43     ` Gary Benson
2014-06-17 14:44 ` [PATCH 09/15] Merge i386_update_inferior_debug_regs Gary Benson
2014-06-17 16:06   ` Pedro Alves
2014-06-17 14:44 ` [PATCH 12/15] Create nat/i386-dregs.h Gary Benson
2014-06-17 16:48   ` Pedro Alves
2014-06-18 11:14     ` Gary Benson
2014-06-17 14:48 ` [PATCH 07/15] Merge error handling Gary Benson
2014-06-17 16:02   ` Pedro Alves
2014-06-17 14:48 ` [PATCH 11/15] Rename functions and make nonstatic as necessary Gary Benson
2014-06-17 16:13   ` Pedro Alves [this message]
2014-06-18 10:25   ` Siva Chandra
2014-06-18 13:30     ` Gary Benson
2014-06-18 13:55       ` Pedro Alves
2014-06-18 14:03         ` Siva Chandra
2014-06-18 14:09         ` Gary Benson
2014-06-18 14:18           ` Pedro Alves
2014-06-17 14:53 ` [PATCH 02/15] Remove unnecessary prototypes Gary Benson
2014-06-17 15:26   ` Pedro Alves
2014-06-17 14:53 ` [PATCH 10/15] Abstract i386_dr_low access Gary Benson
2014-06-17 16:10   ` Pedro Alves
2014-06-17 14:53 ` [PATCH 05/15] Add a const Gary Benson
2014-06-17 15:46   ` Pedro Alves
2014-06-17 14:53 ` [PATCH 08/15] Rename maint_show_dr to debug_hw_points Gary Benson
2014-06-17 16:03   ` Pedro Alves
2014-06-17 14:58 ` [PATCH 13/15] Move macros from i386-{nat,low}.c to i386-{nat,low}.h Gary Benson
2014-06-17 16:54   ` Pedro Alves
2014-06-18 11:33     ` Gary Benson
2014-06-18 11:50       ` Pedro Alves
2014-06-17 14:58 ` [PATCH 15/15] Buildsystem changes Gary Benson
2014-06-17 16:41   ` Pedro Alves
2014-06-17 17:00 ` [PATCH 00/15] Refactor shared code in i386-{nat,low}.[ch] Pedro Alves
2014-06-18 10:49   ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A06911.1030801@redhat.com \
    --to=palves@redhat.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox