From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27445 invoked by alias); 17 Jun 2014 10:03:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27357 invoked by uid 89); 17 Jun 2014 10:03:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jun 2014 10:03:38 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5HA3XAI024015 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Jun 2014 06:03:33 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5HA3VXC031113; Tue, 17 Jun 2014 06:03:32 -0400 Message-ID: <53A01272.4090000@redhat.com> Date: Tue, 17 Jun 2014 10:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Yao Qi CC: Tom Tromey , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [ping] [PATCH] Different outputs affected by locale References: <1401192650-29688-1-git-send-email-yao@codesourcery.com> <538EAEE5.2080708@codesourcery.com> <20140604124708.GR4289@adacore.com> <538F1CC3.9090605@codesourcery.com> <87oay8a0t6.fsf@fleche.redhat.com> <538F803A.9020007@redhat.com> <538FE412.1050806@codesourcery.com> <53903119.6000204@redhat.com> <53903EE5.8090107@codesourcery.com> <539042A2.4050409@redhat.com> <539571C6.40605@codesourcery.com> <53958862.5020106@redhat.com> <5397BCEC.8080300@codesourcery.com> <539990BD.9020504@redhat.com> <5399BB32.5050409@codesourcery.com> <5399E216.1090601@redhat.com> <539FB99C.4020200@codesourcery.com> In-Reply-To: <539FB99C.4020200@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00577.txt.bz2 On 06/17/2014 04:44 AM, Yao Qi wrote: > On 06/13/2014 01:23 AM, Pedro Alves wrote: >> So what I'm thinking is indeed going with making the test >> accept the cent, but conditioned, like: > > OK, that is more restrict. > >> >> # Fallback to assuming 7-bit ASCII. Test are ran under LC_CTYPE=C. >> >> set cent "\\\\242" >> >> set test "show host-charset" >> gdb_test_multiple $test $test { >> -re "CP1252\r\n$gdb_prompt $" { > > I tweak the pattern to match the output... > >> # With Windows code page 1252 (Latin 1), the cent >> # is printable. >> set cent "\u00A2" >> pass $test >> } >> -re "$gdb_prompt $" { >> pass $test >> } >> } > > ... and how about the patch below? > Looks good to me. Thanks, -- Pedro Alves