Re: [RFA 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global

André Pönitz
2019-04-24T20:10:01Z

On Tue, Apr 23, 2019 at 08:54:04AM +0300, Eli Zaretskii wrote:
> > Also here, I don't see enough gain in one suppressed line of output
> > to compensate for the inconsistency, this time even with a CLI user hat on.
>
> Forgive me for asking, but do you frequently debug with GDB on
> Windows?

Not frequently, and if so, only for testing purposes.

But I do get regular feedback from a handful downstream users.

> Because this issue is specific to native Windows debugging,
> it won't affect any other platforms.

The general pattern (subjective inconsistency in GDB output - and
input when I think about it) is, fortunately or not, cross-platform.

> On Windows, we already have
> threads popping up and exiting that are started by the OS beyond our
> control, which is already quite jarring even to me,

[It's not just you in this case...]

> certainly to someone who doesn't debug day in and day out. Having
> the main thread of my program add more noise is not insignificant,
> because ideally I don't want to see any of my application threads
> shown unless my program really started a thread.

To be honest, I have still difficulties to find a mental model on what
irks a typical Windows users. On one hand, they can apparently stand
developing on that platform, on the other hand, two lines of extra
output, even issued for consistency reasons, appear to be a show
stopper.

Andre'