From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112360 invoked by alias); 30 Apr 2019 13:00:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112345 invoked by uid 89); 30 Apr 2019 13:00:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=essence, consists, H*f:sk:1556470, reinstated X-HELO: mail-wm1-f41.google.com Received: from mail-wm1-f41.google.com (HELO mail-wm1-f41.google.com) (209.85.128.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Apr 2019 13:00:43 +0000 Received: by mail-wm1-f41.google.com with SMTP id p21so3721089wmc.0 for ; Tue, 30 Apr 2019 06:00:43 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id k1sm2363640wmi.48.2019.04.30.06.00.40 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 30 Apr 2019 06:00:40 -0700 (PDT) Subject: Re: [v2] Windows native GDB event handling enhancement To: Joel Brobecker , gdb-patches@sourceware.org References: <1555453982-77808-1-git-send-email-brobecker@adacore.com> <1556470691-146942-1-git-send-email-brobecker@adacore.com> From: Pedro Alves Message-ID: <5399f282-0fa2-595e-290c-bf27f2cecb31@redhat.com> Date: Tue, 30 Apr 2019 13:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1556470691-146942-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00643.txt.bz2 On 4/28/19 5:58 PM, Joel Brobecker wrote: > Hello, > > This is v2 of the patch series, which now consists of 2 patches: > > * [RFA v2 1/2] (Windows) fix thr != nullptr assert failure in > > Compared to v1, it has been reduced to the essence of the fix, > which is to avoid using main_thread_id during the exit-process > event; and that's it. > > * [RFA v2 2/2] gdb/windows-nat.c: Get rid of main_thread_id global > > That one shold be unchanged. > > The part that re-instated the thread notifications for the main thread > (at create-process event) and for the last thread (at exit-process > event) has been excised from v1 of patch #1. I think this is the best > compromise based on the discussions so far. > > I will personally miss the silenced notifications, but for those > like me, we can enable the windows event debug logs. > > The reason why I kept the patches split in two is so that I can apply > patch #1 on the gdb-8.3 branch as well. Patch #2 has been behaving > well as far as AdaCore nightly testing is concerned, but it's only > been a few weeks since we implemented it, and I think it deserves > more time in master before being in a release. > > The patches were tested on both 32bit and 64bit native windows, > using AdaCore testsuite. OK to push? LGTM. Thanks, Pedro Alves