From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28733 invoked by alias); 12 Jun 2014 18:17:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28712 invoked by uid 89); 12 Jun 2014 18:17:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jun 2014 18:17:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5CIHkw5028209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Jun 2014 14:17:46 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5CIHjtp012553; Thu, 12 Jun 2014 14:17:45 -0400 Message-ID: <5399EEC8.5080904@redhat.com> Date: Thu, 12 Jun 2014 18:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Pierre Langlois , gdb-patches@sourceware.org Subject: Re: [PATCH v3][PR remote/16896] Invalidate a register in cache when a remote target failed to write it. References: <1402594537-8033-1-git-send-email-pierre.langlois@embecosm.com> In-Reply-To: <1402594537-8033-1-git-send-email-pierre.langlois@embecosm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00520.txt.bz2 Excellent, thanks. On 06/12/2014 06:35 PM, Pierre Langlois wrote: " I was wondering how to go about adding a test for this in > the GDB testsuite. Could we include faulty dummy servers to test each packets?" These two sentences shouldn't really be in the commit log. But to answer, if we can make that work, I don't see why not. I don't think that's a trivial effort though. > + chain_before_invalidate_register = > + make_cleanup_regcache_invalidate (regcache, regnum); I missed this before, but '=' goes on the next line, like: chain_before_invalidate_register = make_cleanup_regcache_invalidate (regcache, regnum); OK with these changes. Thanks! -- Pedro Alves