From: Luis Machado <lgustavo@codesourcery.com>
To: Terry Guo <terry.guo@arm.com>, 'Will Newton' <will.newton@linaro.org>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [Patch]Clean up the XML files for ARM
Date: Wed, 11 Jun 2014 11:24:00 -0000 [thread overview]
Message-ID: <53983C82.4040208@codesourcery.com> (raw)
In-Reply-To: <001701cf8555$40925540$c1b6ffc0$@arm.com>
On 06/11/2014 10:12 AM, Terry Guo wrote:
>
>
>> -----Original Message-----
>> From: Will Newton [mailto:will.newton@linaro.org]
>> Sent: Wednesday, June 11, 2014 4:16 PM
>> To: Terry Guo
>> Cc: gdb-patches@sourceware.org
>> Subject: Re: [Patch]Clean up the XML files for ARM
>>
>> On 11 June 2014 07:46, Terry Guo <terry.guo@arm.com> wrote:
>>> Hi There,
>>>
>>> Under folder gdb/features we are having more and more ARM related XML
>> files.
>>> This patch intends to move those ARM XML files into a new folder named
>> arm.
>>> All the references to those files are now prefixed with folder name arm.
>>> Please be noted that this doesn't include AArch64 XML files so far. Is
>>> it ok to GDB trunk?
>>>
>>> BR,
>>> Terry
>>>
>>> 2014-06-11 Terry Guo <terry.guo@arm.com>
>>>
>>> * features/arm-core.xml: Move to ...
>>> * features/arm/arm-core.xml: ... here.
>>> * features/arm-fpa.xml: Move to ...
>>> * features/arm/arm-fpa.xml: ... here.
>>> * features/arm-m-profile.xml: Move to ...
>>> * features/arm/arm-m-profile.xml: ... here.
>>> * features/arm-vfpv2.xml: Move to ...
>>> * features/arm/arm-vfpv2.xml: ... here.
>>> * features/arm-vfpv3.xml: Move to ...
>>> * features/arm/arm-vfpv3.xml: ... here.
>>> * features/arm-with-iwmmxt.xml: Move to ...
>>> * features/arm/arm-with-iwmmxt.xml: ... here.
>>> * features/arm-with-iwmmxt.c: Move to ...
>>> * features/arm/arm-with-iwmmxt.c: ... here.
>>> * features/arm-with-m.xml: Move to ...
>>> * features/arm/arm-with-m.xml: ... here.
>>> * features/arm-with-m.c: Move to ...
>>> * features/arm/arm-with-m.c: ... here.
>>> * features/arm-with-m-fpa-layout.xml: Move to ...
>>> * features/arm/arm-with-m-fpa-layout.xml: ... here.
>>> * features/arm-with-m-fpa-layout.c: Move to ...
>>> * features/arm/arm-with-m-fpa-layout.c: ... here.
>>> * features/arm-with-m-vfp-d16.xml: Move to ...
>>> * features/arm/arm-with-m-vfp-d16.xml: ... here.
>>> * features/arm-with-m-vfp-d16.c: Move to ...
>>> * features/arm/arm-with-m-vfp-d16.c: ... here.
>>> * features/arm-with-neon.xml: Move to ...
>>> * features/arm/arm-with-neon.xml: ... here.
>>> * features/arm-with-neon.c: Move to ...
>>> * features/arm/arm-with-neon.c: ... here.
>>> * features/arm-with-vfpv2.xml: Move to ...
>>> * features/arm/arm-with-vfpv2.xml: ... here.
>>> * features/arm-with-vfpv2.c: Move to ...
>>> * features/arm/arm-with-vfpv2.c: ... here.
>>> * features/arm-with-vfpv3.xml: Move to ...
>>> * features/arm/arm-with-vfpv3.xml: ... here.
>>> * features/arm-with-vfpv3.c: Move to ...
>>> * features/arm/arm-with-vfpv3.c: ... here.
>>> * features/Makefile: Use new paths to refer ARM files.
>>> * arm-tdep.c: Use new paths to include files.
>>
>> It seems like we have duplicate "arm" in some of the names now, it might be
>> a good cleanup to rename, e.g.:
>>
>> features/arm/arm-vfpv3.xml -> features/arm/vfpv3.xml
>>
>
> Thanks for comments. But files in folder i386 and rs6000 are same as mine. Maybe there are reasons to do so.
>
> For example:
>
> i386/
> i386/i386-mmx.c
> i386/32bit-avx512.xml
> i386/x32-avx512.xml
> i386/x32-avx512-linux.c
> i386/32bit-sse.xml
> i386/32bit-mpx.xml
> i386/i386-avx-linux.xml
> i386/i386-mpx.c
> i386/i386-mpx-linux.xml
> i386/x32-core.xml
> i386/64bit-core.xml
> i386/i386.xml
>
> ./rs6000/powerpc-isa205-altivec64l.xml
> ./rs6000/powerpc-e500l.c
> ./rs6000/powerpc-altivec64l.c
> ./rs6000/powerpc-603.xml
> ./rs6000/powerpc-602.xml
> ./rs6000/power64-core.xml
> ./rs6000/powerpc-64.c
> ./rs6000/powerpc-altivec64.c
> ./rs6000/powerpc-505.xml
>
> BR,
> Terry
I think one of the reasons for having duplication there is that nobody
commented about it, like Will.
I'd go for the cleaner names without the duplication. The duplication
certainly doesn't add anything to it.
Luis
Luis
next prev parent reply other threads:[~2014-06-11 11:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 6:46 Terry Guo
2014-06-11 8:16 ` Will Newton
2014-06-11 9:12 ` Terry Guo
2014-06-11 11:24 ` Luis Machado [this message]
2014-06-12 3:40 ` Terry Guo
2014-06-16 2:12 ` Terry Guo
2014-06-16 7:27 ` Will Newton
2014-06-20 3:05 ` Terry Guo
2014-06-20 5:03 ` Luis Gustavo
2014-06-20 9:52 ` Pedro Alves
2014-06-20 10:21 ` Terry Guo
2014-06-20 11:21 ` Pedro Alves
2014-06-22 4:36 ` Terry Guo
2014-06-23 12:41 ` Pedro Alves
2014-06-25 1:30 ` Terry Guo
2016-10-04 10:11 [PATCH] Clean " Yao Qi
2016-10-04 18:40 ` Pedro Alves
2016-10-05 8:38 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53983C82.4040208@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=terry.guo@arm.com \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox