Re: [PATCH] Delete temporary string within demangler even in failure cases.

Andrew Burgess
2014-06-10T18:08:57Z

On 27/05/2014 2:47 PM, Ian Lance Taylor wrote:
> On Tue, May 27, 2014 at 3:57 AM, Andrew Burgess <aburgess@broadcom.com> wrote:
>>
>> libiberty/ChangeLog
>>
>> * cplus-dem.c (do_type): Call string_delete even if the call to
>> demangle_template fails.
>
> This is OK.
>
> Thanks.
>
> I have to ask: you know this code is not used, right? You're looking
> at the old demangler, for symbols generated by versions of g++ before
> GCC 3.4 (released 2004). The demangler for current versions of g++ is
> in cp-demangle.c.

Sorry for the delay. Yes, I know it's not very old code, but it is
still shipped, and consumers such as gdb can still trigger this code
path.

Thanks for taking a look at this patch for me.

I don't have gcc write permissions, would you (or any other interested
maintainer) mind committing this for me please.

Thanks,
Andrew