Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file()

Chen Gang
2014-06-22T02:01:55Z

On 06/22/2014 07:19 AM, Chet Ramey wrote:
> On 6/20/14, 10:25 PM, Chen Gang wrote:
>
>>> There aren't really any plausible conditions under which write(2) returns
>>> 0 instead of -1 when writing a non-zero number of bytes to a regular file.
>>>
>>
>> Hmm... for me, what you said is acceptable. And the function comment need be
>> changed:
>>
>> "Returns 0 on success, errno or -1 on failure"
>
> history_truncate_file will never return -1.
>

Hmm... do you mean:

"for regular file, write() never return 0, if parameter 'count' > 0?"

or

"if write() return 0, can also return 0 to history_truncate_file()?".

>> And since you will work for it next, is it still necessary to send patch v2 for
>> the temporary fix, at present?
>
> I will take care of making those changes, thanks.

OK, thanks (I need/shall not send patch v2 for it).

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed