Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file()

Chet Ramey
2014-06-21T23:19:19Z

On 6/20/14, 10:25 PM, Chen Gang wrote:

>> There aren't really any plausible conditions under which write(2) returns
>> 0 instead of -1 when writing a non-zero number of bytes to a regular file.
>>
>
> Hmm... for me, what you said is acceptable. And the function comment need be
> changed:
>
> "Returns 0 on success, errno or -1 on failure"

history_truncate_file will never return -1.

> And since you will work for it next, is it still necessary to send patch v2 for
> the temporary fix, at present?

I will take care of making those changes, thanks.

Chet

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/