From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7724 invoked by alias); 10 Jun 2014 18:08:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7701 invoked by uid 89); 10 Jun 2014 18:08:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-gw1-out.broadcom.com Received: from mail-gw1-out.broadcom.com (HELO mail-gw1-out.broadcom.com) (216.31.210.62) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jun 2014 18:08:55 +0000 Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw1-out.broadcom.com with ESMTP; 10 Jun 2014 11:22:02 -0700 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 10 Jun 2014 11:08:53 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.3.174.1; Tue, 10 Jun 2014 11:08:53 -0700 Received: from [10.177.73.41] (unknown [10.177.73.41]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 037869F9F7; Tue, 10 Jun 2014 11:08:52 -0700 (PDT) Message-ID: <539749B5.6020906@broadcom.com> Date: Tue, 10 Jun 2014 18:08:00 -0000 From: Andrew Burgess User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Ian Lance Taylor CC: gcc-patches , Subject: Re: [PATCH] Delete temporary string within demangler even in failure cases. References: <1401188253-15214-1-git-send-email-aburgess@broadcom.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00423.txt.bz2 On 27/05/2014 2:47 PM, Ian Lance Taylor wrote: > On Tue, May 27, 2014 at 3:57 AM, Andrew Burgess wrote: >> >> libiberty/ChangeLog >> >> * cplus-dem.c (do_type): Call string_delete even if the call to >> demangle_template fails. > > This is OK. > > Thanks. > > I have to ask: you know this code is not used, right? You're looking > at the old demangler, for symbols generated by versions of g++ before > GCC 3.4 (released 2004). The demangler for current versions of g++ is > in cp-demangle.c. Sorry for the delay. Yes, I know it's not very old code, but it is still shipped, and consumers such as gdb can still trigger this code path. Thanks for taking a look at this patch for me. I don't have gcc write permissions, would you (or any other interested maintainer) mind committing this for me please. Thanks, Andrew