From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23888 invoked by alias); 9 Jun 2014 13:49:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23869 invoked by uid 89); 9 Jun 2014 13:49:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jun 2014 13:49:23 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s59DnIDV000397 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 Jun 2014 09:49:19 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s59DnGUB029049; Mon, 9 Jun 2014 09:49:17 -0400 Message-ID: <5395BB5C.80106@redhat.com> Date: Mon, 09 Jun 2014 13:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Siva Chandra , gdb-patches CC: Ulrich Weigand Subject: Re: [PATCH] Wrap PyObject_Get/HasAttrString in a function with second arg having const qualifier. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00370.txt.bz2 On 06/09/2014 02:42 PM, Siva Chandra wrote: > +/* The second argument to PyObject_GetAttrString was missing the 'const' > + qualifier. Hence, we wrap it in a function to avoid errors when compiled > + with -Werror against Python 2.4. */ I'd suggest moving the "in Python 2.4" to the first sentence, like: /* The second argument to PyObject_GetAttrString was missing the 'const' qualifier in Python 2.4. Hence, we wrap it in a function to avoid errors when compiled with -Werror. */ Otherwise looks great to me. Thanks! -- Pedro Alves