Re: [ping] [PATCH] Different outputs affected by locale

Yao Qi
2014-06-04T13:21:05Z

On 06/04/2014 08:47 PM, Joel Brobecker wrote:
>>> 2014-05-27 Yao Qi <yao@codesourcery.com>
>>>
>>> * gdb.base/wchar.exp: Execute command 'p repeat[1]' and extract
>>> cent from the output.
>
> This is a patch that I felt would be better reviewed by Tom, but
> we'd have to wait for him to be back. When I read your patch,
> I thought that the approach you took was weakening the test a little,
> because if GDB started printing the character incorrectly, you would
> not notice it anymore.
>

The character printed by GDB in this case is out the control of GDB,
IMO. IOW, we can't tell what character printed is correct and what is
incorrect. Or we can relax the pattern to match either \242 or 'Â¢'
(cent sign) in the test. WDYT?
--
Yao (é½å°§)