From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21628 invoked by alias); 6 Jun 2014 12:27:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21618 invoked by uid 89); 6 Jun 2014 12:27:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Jun 2014 12:27:35 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WstF6-0006vt-47 from Luis_Gustavo@mentor.com for gdb-patches@sourceware.org; Fri, 06 Jun 2014 05:27:32 -0700 Received: from SVR-ORW-FEM-06.mgc.mentorg.com ([147.34.97.120]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 6 Jun 2014 05:27:32 -0700 Received: from [172.30.3.187] (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.2.247.3; Fri, 6 Jun 2014 05:27:31 -0700 Message-ID: <5391B3B1.3040701@codesourcery.com> Date: Fri, 06 Jun 2014 12:27:00 -0000 From: Luis Machado Reply-To: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "Breazeal, Don" , Subject: Re: [PATCH] Fix for follow-fork: followed child doesn't stop References: <1401920383-10219-1-git-send-email-donb@codesourcery.com> <53906D28.5000404@codesourcery.com> <5390E4D1.2050108@codesourcery.com> In-Reply-To: <5390E4D1.2050108@codesourcery.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00317.txt.bz2 Hi Don, On 06/05/2014 10:44 PM, Breazeal, Don wrote: > Hi Luis, > Thanks for the review. > >>> + if (tp->control.step_resume_breakpoint != NULL) >>> + tp->control.step_resume_breakpoint->loc->inserted = 0; >> >> Maybe add a little more context as to why this conditional is doing what >> it is doing? I imagine someone scratching their head to figure this out. >> Your description above makes good sense. > > I added a comment above the conditional. Let me know if it isn't what > you had in mind. > That looks good to me. Thanks. --snip-- > - if [runto_main] then { explicit_fork_parent_follow } > + # The first two tests should be sufficient to test the defaults. > + # There is no need to test using the defaults in other permutations > + # (e.g. "default" "on", "parent" "default", etc.). > + set cases [list [list "default" "default" "next 2"] \ > + [list "default" "default" "continue"] \ > + [list "parent" "on" "next 2"] \ > + [list "parent" "on" "continue"] \ > + [list "child" "on" "next 2"] \ > + [list "child" "on" "continue"] \ > + [list "parent" "off" "next 2"] \ > + [list "parent" "off" "continue"] \ > + [list "child" "off" "next 2"] \ > + [list "child" "off" "continue"]] > + foreach args $cases { > + test_follow_fork [lindex $args 0] [lindex $args 1] [lindex $args 2] > + } > I had suggested what Pedro did, but my mail server wasn't too happy with sending my mails out. Luis