From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [pushed] Don't suppress errors inserting/removing hardware breakpoints in shared libraries.
Date: Fri, 06 Jun 2014 09:00:00 -0000 [thread overview]
Message-ID: <539182B1.2010908@codesourcery.com> (raw)
In-Reply-To: <53917E96.1010607@redhat.com>
On 06/06/2014 04:40 PM, Pedro Alves wrote:
> On 06/06/2014 04:08 AM, Yao Qi wrote:
>> On 06/06/2014 12:01 AM, Pedro Alves wrote:
>>> Yes, but no need to match by target, we can do like e.g.,
>>> gdb.base/signull.exp does, and check whether "x /b 0" manages
>>> to read memory. If so, then skip the test. Any sane target with
>>> an MMU will leave page 0 unmapped, so no need to look for some other
>>> address.
>>
>> How about the patch below?
>>
>
> OK. Thanks!
>
Thanks for the review. Patch is pushed in.
--
Yao (é½å°§)
prev parent reply other threads:[~2014-06-06 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 14:08 Pedro Alves
2014-06-03 9:43 ` Yao Qi
2014-06-05 16:02 ` Pedro Alves
2014-06-06 3:10 ` Yao Qi
2014-06-06 8:41 ` Pedro Alves
2014-06-06 9:00 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539182B1.2010908@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox