From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7324 invoked by alias); 5 Jun 2014 10:27:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7313 invoked by uid 89); 5 Jun 2014 10:27:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jun 2014 10:27:41 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s55ARa2C021525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 5 Jun 2014 06:27:36 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s55ARYvo010376; Thu, 5 Jun 2014 06:27:35 -0400 Message-ID: <53904615.60101@redhat.com> Date: Thu, 05 Jun 2014 10:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Yao Qi CC: Tom Tromey , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [ping] [PATCH] Different outputs affected by locale References: <1401192650-29688-1-git-send-email-yao@codesourcery.com> <538EAEE5.2080708@codesourcery.com> <20140604124708.GR4289@adacore.com> <538F1CC3.9090605@codesourcery.com> <87oay8a0t6.fsf@fleche.redhat.com> <538F803A.9020007@redhat.com> <538FE412.1050806@codesourcery.com> <53903119.6000204@redhat.com> <53903EE5.8090107@codesourcery.com> In-Reply-To: <53903EE5.8090107@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00248.txt.bz2 On 06/05/2014 10:56 AM, Yao Qi wrote: > Yes, it is simple to pass env variable through ssh, but isn't trivial to > pass env variable to host or target in dejagnu, because, > > - ssh is not the only connection dejagnu supports, how about telnet? Well, nobody really uses that for _host_ connections. > - env variable should bind to board. host and target can have > different env vars. > > I saw Jie's patch to set env var on target > http://lists.gnu.org/archive/html/dejagnu/2008-07/msg00000.html > but we need do more than that, IMO. That is the reason I am inclined to > fix the test case instead of the infrastructure (dejagnu). In practice, all real host board files will have a ${board}_spawn override anyway. We can set GDB's vars in a gdb_env array, similar to Jie's patch, and then the ${board}_spawn routine can pass them to $RSH. When/if Jie's patch is extended to bind to board, and accepted upstream, we just set the appropriate new board var to $gdb_env. -- Pedro Alves