From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-113140-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5825 invoked by alias); 4 Jun 2014 20:05:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5727 invoked by uid 89); 4 Jun 2014 20:05:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 20:05:16 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s54K5Bve001975	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Wed, 4 Jun 2014 16:05:12 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s54K5AHJ020928;	Wed, 4 Jun 2014 16:05:10 -0400
Message-ID: <538F7BF5.4010608@redhat.com>
Date: Wed, 04 Jun 2014 20:05:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Siva Chandra <sivachandra@google.com>
CC: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix for PR gdb/17017
References: <CAGyQ6gzKv7KzJsvndX1OGY4_0yPw5ewB=O3F49LdEHkp-N-O7w@mail.gmail.com>
In-Reply-To: <CAGyQ6gzKv7KzJsvndX1OGY4_0yPw5ewB=O3F49LdEHkp-N-O7w@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-06/txt/msg00212.txt.bz2

On 06/04/2014 08:57 PM, Siva Chandra wrote:
> The attached patch should fix PR 17017.
> 
> ChangeLog
> 
> 2014-06-04  Siva Chandra Reddy  <sivachandra@google.com>
> 
>        testsuite/
> 
>         PR gdb/17017
>         * gdb.python/py-xmethods.exp (gdb_test_if_inferiorio): New function.
>         Update few gdb_test invocations to gdb_test_if_inferiorio.


Ah, I hadn't realized the test was relying on IO.  It's unfortunate,
as that way the coverage isn't complete when testing against gdbserver.

Can we make it not rely on IO instead?  You want to be
sure the C++ methods were called, right?

E.g., one idea would be, instead of:

int
B::geta (void)
{
  cout << "From CC B::geta:" << endl;
  return 2 * a;
}

Do:

int B_geta_called;

int
B::geta (void)
{
  B_geta_called++;
  return 2 * a;
}

And then from GDB, read the B_geta_called variable
to tell whether the method was called.  You can e.g.,
use get_integer_valueof for that.

-- 
Pedro Alves