From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29847 invoked by alias); 4 Jun 2014 19:57:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29838 invoked by uid 89); 4 Jun 2014 19:57:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Jun 2014 19:57:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s54Juup1021604 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Jun 2014 15:56:56 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s54Juswc011031; Wed, 4 Jun 2014 15:56:55 -0400 Message-ID: <538F7A06.4040108@redhat.com> Date: Wed, 04 Jun 2014 19:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Siva Chandra , gdb-patches CC: Doug Evans , uweigand@de.ibm.com Subject: Re: [PATCH] Fix py-xmethods.c when compiled with -Werror against Python 2.4 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00210.txt.bz2 On 06/04/2014 07:05 PM, Siva Chandra wrote: > Does the attached patch fix the issue pointed out by Ulrich Weigand > here: https://sourceware.org/ml/gdb-patches/2014-06/msg00169.html > > ChangeLog > 2014-06-04 Siva Chandra Reddy > > * python/py-xmethods.c (invoke_match_method) > (gdbpy_get_matching_xmethod_workers, gdbpy_get_xmethod_arg_types): > Cast the second arg to PyObject_GetAttrString and > PyObject_GetAttrString to char *. > How about we handle this in a central place, like Py_DECREF is handled ? See python-internal.h. -- Pedro Alves