From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: gdb-7.8 branching status (2014-06-04)
Date: Wed, 04 Jun 2014 17:58:00 -0000 [thread overview]
Message-ID: <538F5E3A.8010507@redhat.com> (raw)
In-Reply-To: <538F5D68.9060100@redhat.com>
On 06/04/2014 06:54 PM, Pedro Alves wrote:
> On 06/04/2014 06:46 PM, Joel Brobecker wrote:
>>
>> I'm trying to see if I should define it for LynxOS or not, but
>> then we have the same issue with SPU, I think.
>
> The function is a boolean, so assuming false if the
> hook is NULL is fine:
>
> return (z_type >= '0' && z_type <= '4'
> + && the_target->supports_z_point_type != NULL
> && the_target->supports_z_point_type (z_type));
>
To clarify, neither LynxOS nor SPU install insert_point nor
remove_point hooks either, so the only thing the method
could do if we installed it would be return false. But since
insert_point and remove_point can be NULL, it feels natural
to allow supports_z_point_type to be NULL too.
--
Pedro Alves
next prev parent reply other threads:[~2014-06-04 17:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 17:18 Joel Brobecker
2014-06-04 17:35 ` Pedro Alves
2014-06-04 17:46 ` Joel Brobecker
2014-06-04 17:54 ` Pedro Alves
2014-06-04 17:58 ` Pedro Alves [this message]
2014-06-04 18:17 ` [RFA] gdbserver crash if the_target->supports_z_point_type is NULL Joel Brobecker
2014-06-04 20:09 ` Pedro Alves
2014-06-04 22:21 ` pushed: " Joel Brobecker
2014-06-04 18:20 ` gdb-7.8 branching status (2014-06-04) Joel Brobecker
2014-06-05 13:58 ` Pedro Alves
2014-06-05 14:15 ` Keith Seitz
2014-06-05 14:39 ` Keith Seitz
2014-06-05 21:49 ` Joel Brobecker
2014-06-04 18:41 ` Keith Seitz
2014-06-04 22:23 ` Joel Brobecker
2014-06-05 17:26 ` Doug Evans
2014-06-04 23:03 ` Joel Brobecker
2014-06-05 21:03 ` Joel Brobecker
2014-06-06 16:30 ` Pedro Alves
2014-06-05 21:47 ` Joel Brobecker
2014-06-05 14:40 ` Yao Qi
2014-06-05 16:07 ` Pedro Alves
2014-06-05 21:50 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F5E3A.8010507@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox